Skip to content

[pre-commit.ci] pre-commit suggestions #21273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[pre-commit.ci] pre-commit suggestions #21273

wants to merge 4 commits into from
+9 −7

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Oct 6, 2025 •
edited by github-actions bot
Loading

@pre-commit-ci
[pre-commit.ci] pre-commit suggestions
ace4a84 
updates:
- [github.com/pre-commit/pre-commit-hooks: v5.0.0 → v6.0.0](pre-commit/pre-commit-hooks@v5.0.0...v6.0.0)
- [github.com/astral-sh/ruff-pre-commit: v0.12.2 → v0.13.3](astral-sh/ruff-pre-commit@v0.12.2...v0.13.3)
- [github.com/pre-commit/mirrors-prettier: v3.1.0 → v4.0.0-alpha.8](pre-commit/mirrors-prettier@v3.1.0...v4.0.0-alpha.8)
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025 •
edited
Loading

🌩️ Required checks status: Pending 🟡

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success ✅

These checks are required after the changes to tests/tests_pytorch/graveyard/test_precision.py, tests/tests_pytorch/utilities/test_model_helpers.py.

🟡 pytorch_lightning: lit GPU
Check ID Status
pytorch.yml / Lit Job (nvidia/cuda:12.1.1-runtime-ubuntu22.04, pytorch, 3.10) no_status ❓
pytorch.yml / Lit Job (lightning, 3.12) no_status ❓
pytorch.yml / Lit Job (pytorch, 3.12) no_status ❓

These checks are required after the changes to tests/tests_pytorch/graveyard/test_precision.py, tests/tests_pytorch/utilities/test_model_helpers.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 70 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 6, 2025
@codecov Codecov
Copy link

codecov bot commented Oct 6, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79%. Comparing base (79dc82c) to head (e3d986e).
✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (79dc82c) and HEAD (e3d986e). Click for more details.

HEAD has 117 uploads less than BASE
Flag BASE (79dc82c) HEAD (e3d986e)
cpu 54 27
python 6 3
lightning_fabric 14 0
pytest 30 0
python3.10 12 6
lightning 31 15
python3.11 12 6
python3.12 6 3
python3.12.7 18 9
gpu 3 0
Additional details and impacted files 
@@            Coverage Diff            @@
##           master   #21273     +/-   ##
=========================================
- Coverage      87%      79%     -8%     
=========================================
  Files         269      266      -3     
  Lines       23690    23635     -55     
=========================================
- Hits        20668    18641   -2027     
- Misses       3022     4994   +1972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@deependujha deependujha deependujha approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees
No one assigned
Labels
pl Generic label for PyTorch Lightning package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Borda @SkafteNicki @deependujha